contain-google icon indicating copy to clipboard operation
contain-google copied to clipboard

[Enhancement] Only contain google when not already in a container

Open BenjaminVanRyseghem opened this issue 7 years ago • 3 comments

hey, first of all, a lot of kudos for your add on 👍

My use case is that I have my personal google account that I want to be contained (using your add on), but I also have a "work" container with a dedicated google account (no choice there)

The problem is that I have SSO enabled with my work-related google account (like Jira), but now when I try to log in to Jira from within my work container, it fails (as my personal account is used due to your add-on).

Would it be possible then to have your add on working only on non-contained pages?

Thanks again, Benjamin Van Ryseghem

BenjaminVanRyseghem avatar May 09 '18 13:05 BenjaminVanRyseghem

Thank you for liking the addon.

I have heard this problem already from several persons, however I have almost nothing to do with Javascript. I just forked the addon and adjusted the strings and the domains.

If possible, you are welcome to submit a PR, which I will merge. I'll leave this issue open for a while, see if anyone can be found. I'm sorry.

Perflyst avatar May 09 '18 16:05 Perflyst

I'll have a look then 😄 (js is kinda my thing 😛)

BenjaminVanRyseghem avatar May 09 '18 16:05 BenjaminVanRyseghem

See also Facebook Container #96

Perflyst avatar May 09 '18 16:05 Perflyst