contain-google icon indicating copy to clipboard operation
contain-google copied to clipboard

Update core

Open hackerncoder opened this issue 4 years ago • 2 comments

The addon works great and does what it needs to do. However the core was forked 3 years ago, and in this time contain-facebook has gotten more than a 1000 commits, which we haven't added into our fork.

I was thinking about creating updating and keeping somewhat up to date with contain-facebook, or maybe creating a different addon that would keep up to date. I just wanted others input on this before I started, so that I don't waste my time if it is a bad idea.

hackerncoder avatar Jan 08 '21 16:01 hackerncoder

I haven't really followed the changes there. If there are useful changes that can make this addon better, we should of course make use of them

Perflyst avatar Jan 09 '21 13:01 Perflyst

Checking contain-facebook, the only differece is it has a icon on the toolbar with an explanation and the "add domain into facebook container". contain-google have many other options but inside the preferences tab. Maybe internally works better or have some bugs fixed, I don't know...

In my opinion, the only upgrade that could be interesting would be to import the toolbar and put all preferences inside. But for my, the contain-google as now is enought.

@hackerncoder , let me know if you need help on that

situplastik avatar Mar 04 '21 08:03 situplastik