Why not expose netlin.LinkAttrs in parameter to config queue number of veth pair？

Open victory460 opened this issue 2 years ago • 1 comments

https://github.com/containernetworking/plugins/blob/9d9ec6e3e18ea245b9cef0f8396e570247338d1f/pkg/ip/link_linux.go#L34-L39

Why not expose netlin.LinkAttrs in parameter to config queue number of veth pair？ like this code:

func makeVethPair(linkAttr netlink.LinkAttrs, peer string, mac string, hostNS ns.NetNS) (netlink.Link, error) {
	veth := &netlink.Veth{
		LinkAttrs:     linkAttr,
		PeerName:      peer,
		PeerNamespace: netlink.NsFd(int(hostNS.Fd())),
	}

we want to config rx queue number of veth pair.

Aug 21 '23 07:08 victory460

@victory460 what are the benifits of using multiple queue numbers for a veth device?

Dec 28 '23 12:12 ruicao93