plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Published 20 hours ago • verified publisher icon containernetworking

Updated the hardcoded dependencies

Open yashsingh74 opened this issue 2 years ago • 3 comments

The PR fixes the following changes-

  • Allow default run args -it to be overridden by specifying DOCKER_RUN_ARGS.
  • Introduce GO_IMAGE and GO_VERSION to allow the compiliation docker image to be specified.
  • Add logic to handle the case where a non alpine golang image is used so that the script no longer blindly attempts to apk install bash and tar. Scripts checks for presence of both commands.
  • Avoid using dos2unix, use sed

yashsingh74 avatar Feb 22 '23 10:02 yashsingh74

cc: @squeed

yashsingh74 avatar Feb 23 '23 02:02 yashsingh74

@squeed can you review this PR as well.

yashsingh74 avatar Mar 01 '23 13:03 yashsingh74

cc: @dcbw

yashsingh74 avatar Mar 02 '23 13:03 yashsingh74

@squeed Please review the PR.

yashsingh74 avatar Apr 29 '24 04:04 yashsingh74