plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Published 20 hours ago • verified publisher icon containernetworking

TODO: release "installer" docker image

Open squeed opened this issue 2 years ago • 11 comments

It would be useful to release a cni docker image with the plugins. It would be even more awesome if it was signed with chainguard / cosign.

It could either be based on alpine / busybox so that it includes cp, or go distroless for use as a base image.

Just need to figure out how to do multiarch docker builds.

  • [ ] Dockerfile to build CNI plugins. Bonus points for playing nice with dependabot.
  • [ ] Multiarch Dockerfile for released "installer" image
  • [ ] Fixup release.sh to use this (or some equivalent)
  • [ ] Build releases automatically via GitHub and push them to ghcr
  • [ ] Cosign all the things!

squeed avatar Jan 10 '23 10:01 squeed

I have a distroless container version for the dhcp / bridge plugins here: https://github.com/EmilyShepherd/kiOS/tree/main/pkgs/images/dhcp-cni. It's multiarch (amd64 and arm64 with musl and a small init binary for copying the binaries)

At the moment this is fairly coupled to the wider project it's part of, but I'd be happy to take some learnings of this to contribute a more generalised build if that would be helpful 😊

EmilyShepherd avatar Jan 10 '23 17:01 EmilyShepherd

@EmilyShepherd heck yeah, feel free. And don't worry about getting everything all done at once.

Also, nothing in release.sh is sacred; change whatever you need to make it work.

squeed avatar Jan 11 '23 11:01 squeed

@squeed can I help in any of the given open items. Happy to help.

yashsingh74 avatar Feb 11 '23 14:02 yashsingh74

@yashsingh74 please feel free! @EmilyShepherd, have you found any time :-)?

squeed avatar Feb 13 '23 10:02 squeed

Sorry I have been distracted by other things - happy for you to look at this @yashsingh74

EmilyShepherd avatar Feb 14 '23 15:02 EmilyShepherd

Thanks, I will work on it then.

yashsingh74 avatar Feb 14 '23 16:02 yashsingh74

Hey guys, I managed to get multiarch working, based on work in #245. Should I open a new PR or reopen #245? It's on my fork: https://github.com/leojonathanoh/plugins/pull/1

leojonathanoh avatar Feb 21 '23 14:02 leojonathanoh

great @leojonathanoh. I am also working on it. But if you already have the code ready. Please go ahead.

yashsingh74 avatar Feb 21 '23 15:02 yashsingh74

It will be good to see your work too, maybe you might have solved it better. I haven't done cosign yet, not very familiar with it.

leojonathanoh avatar Feb 21 '23 15:02 leojonathanoh

@leojonathanoh please raise the PR. I will also see if I can do better on it. Thanks :)

yashsingh74 avatar Feb 28 '23 14:02 yashsingh74

Alright, will do :)

leojonathanoh avatar Mar 01 '23 08:03 leojonathanoh