plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Add support for in-container master for vlans

Open mmirecki opened this issue 2 years ago • 1 comments

Add support for in-container master for the vlan plugin

mmirecki avatar Nov 15 '22 11:11 mmirecki

@dougbtv @dcbw @s1061123 Could you please take a look?

mmirecki avatar Nov 15 '22 13:11 mmirecki

/cc @dougbtv @s1061123

mmirecki avatar Nov 21 '22 09:11 mmirecki

This seems fairly straightforward to me, at least the code changes. But, I'm also interested in what we'll provide for docs / explain the usage as well.

dougbtv avatar Dec 06 '22 19:12 dougbtv

This seems fairly straightforward to me, at least the code changes. But, I'm also interested in what we'll provide for docs / explain the usage as well.

We have this doc PR for this: https://github.com/containernetworking/cni.dev/pull/109

mmirecki avatar Dec 07 '22 07:12 mmirecki

Almost good. Thank you for the PR.

BTW, is there any reason why you don't add tests for 'linkInContainer' option in vlan_test.go?

Tests modified. Thanks for catching this.

mmirecki avatar Dec 14 '22 10:12 mmirecki

@dcbw can you please take a look?

mmirecki avatar Jan 05 '23 13:01 mmirecki

/lgtm /approve

mccv1r0 avatar Feb 05 '23 14:02 mccv1r0