plugins
plugins copied to clipboard
Add support for in-container master for vlans
Add support for in-container master for the vlan plugin
@dougbtv @dcbw @s1061123 Could you please take a look?
/cc @dougbtv @s1061123
This seems fairly straightforward to me, at least the code changes. But, I'm also interested in what we'll provide for docs / explain the usage as well.
This seems fairly straightforward to me, at least the code changes. But, I'm also interested in what we'll provide for docs / explain the usage as well.
We have this doc PR for this: https://github.com/containernetworking/cni.dev/pull/109
Almost good. Thank you for the PR.
BTW, is there any reason why you don't add tests for 'linkInContainer' option in vlan_test.go?
Tests modified. Thanks for catching this.
@dcbw can you please take a look?
/lgtm /approve