plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Pass status along ipam

Open maiqueb opened this issue 1 year ago • 6 comments

This PR bumps the plugins to use CNI 1.2.0 and allows delegating the STATUS verb to IPAM plugins.

This way, other CNI plugins implementing STATUS can delegate the STATUS calls to IPAM CNIs.

maiqueb avatar May 27 '24 16:05 maiqueb

@LionelJouin very good point. Do you think this affects more than just tests? I'm not sure if there's anything that embeds types.NetConf that also marshal to disk. But, we probably need to revert https://github.com/containernetworking/cni/pull/1039

squeed avatar Jun 03 '24 15:06 squeed

Could be. I created a ticket for it: https://github.com/containernetworking/cni/issues/1096 SBR (flaking) and tuning plugins are also failing, but I haven't checked the reason yet.

LionelJouin avatar Jun 03 '24 15:06 LionelJouin

Is this ready to merge, or will you be implementing STATUS passthrough in this PR?

squeed avatar Jul 15 '24 14:07 squeed

Is this ready to merge, or will you be implementing STATUS passthrough in this PR?

@squeed did you mean GC ? This PR does just that (i.e. status passthrough).

I'd rather defer GC to another PR.

maiqueb avatar Jul 15 '24 15:07 maiqueb

I don't see anything providing an implementation of Status, so this PR lays the groundwork but doesn't, AFAICT, pass STATUS to a delegated plugin.

squeed avatar Jul 15 '24 15:07 squeed

I don't see anything providing an implementation of Status, so this PR lays the groundwork but doesn't, AFAICT, pass STATUS to a delegated plugin.

I see !

Yeah, let's defer that as well :)

maiqueb avatar Jul 15 '24 15:07 maiqueb

This was done in #1082

squeed avatar Jul 21 '25 15:07 squeed