ttrpc icon indicating copy to clipboard operation
ttrpc copied to clipboard

New branch for removing gogo/protobuf

Open kzys opened this issue 2 years ago • 3 comments

I've been working on upgrading protobuf packages in containerd. Now Protobuild supports new protoc-gen-go and #96 will add new protoc-gen-go-ttrpc which should be able to generate ttrpc code that works with the new protoc-gen-go.

However, next few PRs will make some backward-incompatible changes, namely

  • Removing gogo/protobuf from ttrpc itself
  • Updating example/

Since ttrpc is used by containerd which has relatively long support policy, we would make some enhancements such as #75 and #94. So I'm reluctant to make ttrpc's main branch incompatible with gogo/protobuf right now.

Instead, could we have a branch to remove gogo/protobuf? If so, do we want to do Go-style branching (e.g. v2) instead of containerd-style (release/1.0)?

kzys avatar Oct 26 '21 17:10 kzys

I think a release/1.0 branch is reasonable. This is what we have done in other dependent projects as well

dmcgowan avatar Oct 26 '21 17:10 dmcgowan

Sounds good to me. Let me clean up open PRs. I'd like to merge 1.0.x enhancements before cutting the branch.

kzys avatar Oct 26 '21 19:10 kzys

Should this be closed?

dcantah avatar Jan 29 '24 22:01 dcantah