ttrpc-rust icon indicating copy to clipboard operation
ttrpc-rust copied to clipboard

can we change protobuf to tokio-rs/prost?

Open ningmingxiao opened this issue 1 year ago • 9 comments

tokio-rs/prost is more mature than protobuf. and may use less mem

ningmingxiao avatar Oct 11 '24 09:10 ningmingxiao

+1 on this prost is used by tonic and provides better ergonomics in Rust

jprendes avatar Nov 19 '24 18:11 jprendes

@fuweid @wllenyj @Tim-Zhang Is an update like this something you would be open to?

jsturtevant avatar Nov 19 '24 18:11 jsturtevant

sounds good to me. +1 on this

fuweid avatar Nov 19 '24 18:11 fuweid

Hi @ningmingxiao We have made technical reserves: https://github.com/containerd/ttrpc-rust/pull/173.

We can reopen it and move this forward @justxuewei.

@ningmingxiao @jprendes @jsturtevant Can you please help to advance this project, such as helping with testing and review?

Tim-Zhang avatar Feb 05 '25 09:02 Tim-Zhang

Hey guys, I'm afraid that I don't have enough time for working on this recently. I managed to switch from protobuf to prost about two years ago, see https://github.com/containerd/ttrpc-rust/pull/173, as mentioned by @Tim-Zhang. But I think it needs to be revisited and improved. Any volunteer to move this work forward?

justxuewei avatar Feb 10 '25 03:02 justxuewei

I'd like to continue your work in my free time @justxuewei

jokemanfire avatar Feb 19 '25 07:02 jokemanfire

I'd like to continue your work in my free time @justxuewei

@jokemanfire Cool! Please feel free to let me know if any issues here ;)

justxuewei avatar Feb 19 '25 07:02 justxuewei

I'd like to continue your work in my free time @justxuewei

@jokemanfire Cool! Please feel free to let me know if any issues here ;)

Could I file a new pr ?and I will add your signature.

jokemanfire avatar Feb 20 '25 02:02 jokemanfire

Could I file a new pr ?and I will add your signature.

Yes, of course.

justxuewei avatar Feb 20 '25 02:02 justxuewei