rust-extensions

rust-extensions copied to clipboard

Frankly speaking (in longer term) I think we should not carry cgroups related code in the `shim` crate. shim crate supposed to be the foundation for building new shim runtimes...

Mossaka

is there any concern about resolving symlinks or relative paths via canonicalize here? _Originally posted by @jsturtevant in https://github.com/containerd/rust-extensions/pull/254#discussion_r1526631985_

Mossaka

Path of cgroup is wrong when running a container in a container.

7

https://github.com/containerd/rust-extensions/blob/main/crates/shim/src/cgroup.rs#L195 [cgroup-rs](https://github.com/kata-containers/cgroups-rs/issues/131)

aa624545345

Feature: Add oom monitor for cgroupv2.

3

Add oom monitor for cgroupv2.

aa624545345

Remove read_file_to_str helper

1

Use `fs::read_to_string` from stdlib/tokio instead.

mxpv

There was a report that we saw a speed up in runwasi after turning logging off. #247 makes logging configurable but we should investigate the report: I _suspect_ that the...

jsturtevant

if delete the process but the process's io still used by other process.tell ctr io still in use by other process.

10

find this error in ctr v1.7 "TestContainerDrainExecIOAfterExit" ,if ctr send 'delete' info to shim ,the shim return ok ,the ctr will think that IO is being closed. but this IO...

jokemanfire

Support client create on Windows

2

Allow for using the client create on Windows (https://github.com/containerd/rust-extensions/tree/main/crates/client). Currently it fails to build with: ``` error[E0432]: unresolved import `tokio::net::UnixStream` --> C:\Users\jstur\.cargo\registry\src\index.crates.io-6f17d22bba15001f\containerd-client-0.4.0\src\lib.rs:81:9 | 81 | use tokio::net::UnixStream; | ^^^^^^^^^^^^^^^^^^^^^^ no...

jsturtevant

Bug: pod restarted after containerd restarted when container IO is huge

1

We have found a bug that pods restarted after containerd restarted, especially on the condition that the container IO is very frequent. The parent process of the container processm that...

Burning1020

ContainerAttach integration tests flaking

1

``` 2023-09-27T16:54:46.0829155Z === CONT TestContainerAttachProcess 2023-09-27T16:54:46.2301858Z container_linux_test.go:716: write /proc/self/fd/29: broken pipe 2023-09-27T16:54:46.2314358Z container_linux_test.go:724: write /proc/self/fd/29: broken pipe 2023-09-27T16:54:46.2384256Z container_linux_test.go:746: expected output "hello\nhello\n" but received "" 2023-09-27T16:54:46.2591524Z --- FAIL: TestContainerAttachProcess (0.18s)...

jsturtevant