rust-extensions icon indicating copy to clipboard operation
rust-extensions copied to clipboard

.github/workflows/ci: add machete to CI

Open Mossaka opened this issue 1 year ago • 2 comments

this will check if there are unused deps in this repo

Mossaka avatar Sep 30 '24 21:09 Mossaka

Try rebase?

mxpv avatar Oct 04 '24 20:10 mxpv

Ah the issue was not about rebase. The error from cargo machete says

containerd-snapshots -- ./crates/snapshots/Cargo.toml:
	prost
containerd-client -- ./crates/client/Cargo.toml:
	prost

we probably want to ignore prost dependency as it's actually being used.

Mossaka avatar Oct 04 '24 21:10 Mossaka

Can we merge this PR? @mxpv

Mossaka avatar Nov 05 '24 08:11 Mossaka

@Mossaka could you pls rebase against latest main? Looks like there is a CI issue that needs to be addressed first.

mxpv avatar Nov 05 '24 19:11 mxpv

Looks like I need to rebase this one

Mossaka avatar Nov 05 '24 19:11 Mossaka