runwasi icon indicating copy to clipboard operation
runwasi copied to clipboard

Containerd breaking change in main branch

Open Mossaka opened this issue 2 years ago • 3 comments

currently on the main branch containerd only issues shim delete for the sandbox during sandbox cleanup.

ref: https://github.com/containerd/containerd/issues/9727

Mossaka avatar Feb 06 '24 18:02 Mossaka

thanks a ton for looking into this, @Mossaka

squillace avatar Feb 06 '24 18:02 squillace

I ran all our tests against the main branch containerd and all passed.

Mossaka avatar Feb 07 '24 19:02 Mossaka

from the issue it looks like we just need to avoid mixing shim versions https://github.com/containerd/containerd/issues/9727#issuecomment-1958594294

So, it looks unsafe to use current podsandbox mode to integrate with old version shim. That's why I say that we should update shim doc and highlight it changelog.

I tried to add a nightly job using kind but it didn't work since Kind currently fails to load images since it can't parse the new containerd config version 3 yet.

https://github.com/containerd/runwasi/compare/main...jsturtevant:runwasi:add-nightly-contianerd-job?expand=1

If fails with ERROR: failed to detect containerd snapshotter since kind image loader parses the wrong config layout: https://github.com/kubernetes-sigs/kind/blob/c83316d25e1c40f1c66982b637edf3ee34a5e0d4/pkg/cluster/nodeutils/util.go#L105-L108

jsturtevant avatar Mar 06 '24 18:03 jsturtevant