nydus-snapshotter icon indicating copy to clipboard operation
nydus-snapshotter copied to clipboard

[Feat] Support reconvert image from nydus to oci

Open basuotian opened this issue 6 months ago • 7 comments

Feat: https://github.com/dragonflyoss/nydus/issues/1682

The current implement is very rough as some logic should be changed in "github.com/containerd/containerd/v2/core/images/converter". (see unit test testImageReConvertBasic)

Please take a look and see if is necessary to open a pr to containerd.

basuotian avatar May 27 '25 09:05 basuotian

@basuotian Thanks for the PR! How about moving the containerdreconverter codes into a forked nydus-snapshotter repo? This way we can clearly see the diff of the changes. :)

imeoer avatar Jun 10 '25 02:06 imeoer

@basuotian Thanks for the PR! How about moving the containerdreconverter codes into a forked nydus-snapshotter repo? This way we can clearly see the diff of the changes. :)

OK, I did move containerdreconverter into repo github.com/basuotian/nydus-snapshotter-reconverter, and these codes should be part of github.com/containerd/containerd/v2/core/images. @imeoer PTAL

basuotian avatar Jun 11 '25 08:06 basuotian

@BraveY Thanks for review, fixed follow your recommendations, PTAL

basuotian avatar Jun 19 '25 03:06 basuotian

@basuotian Thanks for the PR! Have you modified the code related to the nydusify convert command? Nydusify also needs to support the reconvert feature. Maybe @Zephyr could help implement this.

BraveY avatar Jun 20 '25 03:06 BraveY

@basuotian Thanks for the PR! Have you modified the code related to the nydusify convert command? Nydusify also needs to support the reconvert features. Maybe @zephyr could help implement this.

Yes, i have already finished the code in nydusify, as nydusify depends on nydus-snapshotter so this pr run first

basuotian avatar Jun 23 '25 08:06 basuotian

Thanks, Others LGTM! @imeoer cc

BraveY avatar Jun 25 '25 02:06 BraveY

@basuotian hi would you fix the broken lint CI? thanks!

BraveY avatar Sep 15 '25 07:09 BraveY