nydus-snapshotter icon indicating copy to clipboard operation
nydus-snapshotter copied to clipboard

snapshot: fix error on proxy driver when switching different snapshotter

Open ChengyuZhu6 opened this issue 1 year ago • 3 comments

Fixes: #592

ChengyuZhu6 avatar Apr 28 '24 08:04 ChengyuZhu6

cc @imeoer

ChengyuZhu6 avatar Apr 28 '24 09:04 ChengyuZhu6

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 34.36%. Comparing base (b8ffddf) to head (8b98d6a). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   34.64%   34.36%   -0.29%     
==========================================
  Files          65       65              
  Lines        6552     6606      +54     
==========================================
  Hits         2270     2270              
- Misses       3967     4021      +54     
  Partials      315      315              
Files Coverage Δ
snapshot/process.go 0.00% <0.00%> (ø)
snapshot/snapshot.go 0.00% <0.00%> (ø)

codecov[bot] avatar Apr 28 '24 09:04 codecov[bot]

@ChengyuZhu6 Thanks! I'll try to reproduce the bug and test the PR.

imeoer avatar Apr 28 '24 13:04 imeoer

This does work around the problem we've encountered when using guest-pull with Confidential Containers. More than working around the issue, it gives us enough time to work on containerd (which has a pace of release and adoption that can be slow to reach all the CSPs) fix without worrying much about which version of containerd will be used with Confidential Containers.

Huge thumbs up for having this one in!

fidencio avatar May 10 '24 08:05 fidencio

@ChengyuZhu6, I'd love to see, as part of the commit message, as much information as you provided in the issue. This will help us, later on, to figure out why those changes were made without having to come back to GitHub to do so.

fidencio avatar May 10 '24 08:05 fidencio

FYI - I've also testing this code and quay.io/chengyu_zhu/nydus-snapshotter@sha256:4b5e333ecd27d7b630cbe42fe686f8b3c38df7727c99f4b5cef724be6f3926fa with peer pods and it seemed to work without the workaround of cleaning up the images and content on the node. Amazing work!

stevenhorsman avatar May 10 '24 10:05 stevenhorsman