nydus-snapshotter icon indicating copy to clipboard operation
nydus-snapshotter copied to clipboard

Need an e2e test for nydus integrated with p2p

Open sctb512 opened this issue 2 years ago • 2 comments

We should add an e2e test for nydus integrated with p2p, which includes the following cases:

  1. p2p is the only mirror and does not work, fall back to the original registry.
  2. p2p is the only mirror and works, all is well.
  3. p2p is not the only mirror and does not work, try the next mirror.
  4. p2p is the only mirror and auth_through is true, unauthorized requests are sent to the p2p server.
  5. A normal registry is the only mirror(auth_through must be true).

sctb512 avatar Mar 29 '23 13:03 sctb512

Thanks for considering this. Frankly speaking, the test for it is fragile.

changweige avatar Mar 30 '23 01:03 changweige

Currently, we do have some tests in https://github.com/dragonflyoss/Dragonfly2/actions/workflows/nydus-e2e.yml, but adding more tests would be good.

adamqqqplay avatar Mar 31 '23 09:03 adamqqqplay