NRI network
Implementation of NRI network messages. The messages added are:
- NetworkConfigurationChanged when the CNI config has been read from disk
- PreSetupNetwork before CNI is set up
- PostSetupNetwork after successful CNI configuration
- Pre- and PostNetworkDeleted once the pod network is removed
Fixed forgotten test cases and NetworkDeleted functionality
Codecov Report
Attention: 195 lines in your changes are missing coverage. Please review.
Comparison is base (
c68cf49) 64.61% compared to head (40fbd54) 58.27%.
:exclamation: Current head 40fbd54 differs from pull request most recent head ce1e5a1. Consider uploading reports for the commit ce1e5a1 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 64.61% 58.27% -6.34%
==========================================
Files 9 9
Lines 1834 2030 +196
==========================================
- Hits 1185 1183 -2
- Misses 498 696 +198
Partials 151 151
| Files | Coverage Δ | |
|---|---|---|
| pkg/adaptation/adaptation.go | 61.14% <0.00%> (-11.55%) |
:arrow_down: |
| pkg/adaptation/plugin.go | 40.58% <0.00%> (-8.01%) |
:arrow_down: |
| pkg/adaptation/result.go | 71.02% <1.07%> (-8.82%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Plugin fixed to match expected functions
Removed 'WIP' labels as this PR has progressed into something decently useful.
/cc
Let's revisit this PR once KNI has taken shape. At that point we will learn whether any CNI specific plugins will be needed or if plugins interested in network activity listen to KNI instead.
@pfl want to reopen this?
Once KNI messaging gets specified, NRI plugins may perhaps hook into KNI directly. If needed, a non-KNI NRI based setup should be as close to a KNI one as possible in order to avoid excessive coding and added architecture. Right now I'm unfortunately (de)allocated to some DRA work until mid Q3. Thus the pause in this PR.