nri icon indicating copy to clipboard operation
nri copied to clipboard

[Proposal] Support adjust Linux Network Devices

Open aojea opened this issue 6 months ago • 7 comments

Mirroring https://github.com/cncf-tags/container-device-interface/issues/267, I thought we already have one, but I can't find it, quoting @kad

With https://github.com/opencontainers/runtime-spec/pull/1271 now merged in the runtime spec, we can start exploring how we can add support for adjusting this runtime spec field

aojea avatar Jun 19 '25 11:06 aojea

Great 👍 I think this is valuable.

I'm interested in implementing it

tao12345666333 avatar Jun 20 '25 01:06 tao12345666333

@tao12345666333 this is a container adjustment, so I would check on an existing ones to base the implementation on that. Also check with the maintainers like @samuelkarp and @klihub , at the end of the day, they are the ones that decide

aojea avatar Jun 24 '25 08:06 aojea

OK, thank you let me know. 🤗

tao12345666333 avatar Jun 24 '25 08:06 tao12345666333

@aojea @tao12345666333 There is already an implementation which is just waiting for the necessary OCI Spec bits to get tagged, so we wouldn't need to have a commit-reference in go.mod. It's here: https://github.com/klihub/nri/tree/devel/linux-net-devices

I also thought we have a draft PR open for/from it, but looks like we don't. I'll open one for it now.

klihub avatar Jun 24 '25 11:06 klihub

@aojea @tao12345666333 Actually we already have a draft PR open for this: #157

klihub avatar Jun 24 '25 11:06 klihub

Sorry, I totally forget about it

aojea avatar Jun 24 '25 19:06 aojea

@klihub this is awesome , since runc already merged support last week https://github.com/opencontainers/runc/pull/4538 , can we proceed?

aojea avatar Jun 25 '25 05:06 aojea