api,adaptation,generate: allow adjusting linux net devices

[klihub]

Allow plugins to adjust linux net devices.

Notes: This PR is marked a draft since it uses an untagged opencontainers/runtime-spec version v1.2.2-0.20250401095657-e935f995dd67. Once a new version is tagged, we can mark this PR ready for review. Testing this requires

• a patched runc with support for LinuxNetDevice injection, @aojea has a pending PR
• a patched runtime, I tested with this

[aojea]

❤️

[klihub]

/cc @aojea @tao12345666333 Here is the draft PR proposal #180 was asking for.

[aojea]

This is fantastic @klihub , can we undraft it for final review

[klihub]

This is fantastic @klihub , can we undraft it for final review

We can try to do that to get it reviewed. @mikebrow WDYT?

But I think we won't be able to get this merged before the necessary new bits in runtime-spec gets behind a tag. Both CRI-O and containerd main/HEAD is at [email protected] and I think we usually tend to stick to a tagged version in both even in main.

[aojea]

ok, that is fair

[aojea]

Fixes: #180

[aojea]

Containerd https://github.com/containerd/containerd/pull/12295 is already testing runc 1.4.0-rc.2 CRIO uses crun that already has the feature https://github.com/containers/crun/releases/tag/1.22 OCI spec is close to release the definitive 1.3.0 https://github.com/opencontainers/runtime-spec/issues/1295

[mikebrow]

Thx for the update @aojea

[klihub]

Containerd containerd/containerd#12295 is already testing runc 1.4.0-rc.2 CRIO uses crun that already has the feature https://github.com/containers/crun/releases/tag/1.22 OCI spec is close to release the definitive 1.3.0 opencontainers/runtime-spec#1295

@aojea @mikebrow But I think we'd still need a tagged version of opencontainers/runtime-spec we could point ourselves at.

[aojea]

@klihub yeah, I was using the comment as a breadcrumb , so next time I check I can track teh history, otherwise I forget

I was not trying to push for merging before that, sorry for the confusion

[klihub]

@klihub yeah, I was using the comment as a breadcrumb , so next time I check I can track teh history, otherwise I forget

I was not trying to push for merging before that, sorry for the confusion

@aojea No prob / no offense taken. I just asked to make sure I understand correctly where we are and whether we can try to move this forward yet.

[aojea]

informational update , ETA for 1.3.0 spec is 2025/11/04 https://github.com/opencontainers/runc/issues/4875#issuecomment-3454561451 , runc will follow

[klihub]

@aojea @mikebrow With opencontainers/runtime-spec v1.3.0 now tagged and released, unfortunately opencontainer/runtime-tools is now badly out of sync with runtime-spec.

[email protected] brings a flips the linux PID limit setting the from int64 to *int64. While this allows to set an 'unlimited' limit using nil, it is a backward incompatible change and it essentially makes it impossible to import [email protected] and runtimes-tools@current HEAD to the same golang code base.

I filed a PR for fixing this but I'm not sure what are the chances of getting that merged soon

[aojea]

it seems the dependency problem got unblocked