containerd
nerdctl checkpoint command support
What is the problem you're trying to solve
To support the checkpoint feature in nerdctl.
Describe the solution you'd like
I'll make a try to support the checkpoint feature in the nerdctl with the following steps
- I will implement three commands
- nerdctl checkpoint create
- nerdctl checkpoint ls
- nerdctl checkpoint rm
- Add a new flag
--checkpointinnerdctl startcommand.
Additional context
For now, maybe we can only support checkpoint feature for Linux
According to this issue https://github.com/checkpoint-restore/criu/issues/860
If we want to add a checkpoint command to the nerdctl, there will be some error in CI before the kernel and CRIU project fix this issue
this is implemented in ctr https://github.com/containerd/containerd/blob/main/cmd/ctr/commands/run/run.go#L188 do they have the same problem !?
@fahedouch The answer is yes.
The containerd tested the checkpoint feature base on Ubuntu 20.04 with kernel 5.4.
But in the newest kernel, 5.13, the command would be failed.
Actually, I'm not sure we need to add this command because the CRIU is not stable
Per discussion in #checkpoint-restore/criu/issues/860 the issue was fixed.
Actually, I'm not sure we need to add this command because the CRIU is not stable
docker, ctr and runc have checkpoint feature, so it would be cool if nerdctl also had it. I'd say CRIU is quite stable, just that it depends on the Linux kernel which may have bugs and new features.
Per discussion in #checkpoint-restore/criu/issues/860 the issue was fixed.
Actually, I'm not sure we need to add this command because the CRIU is not stable
docker,ctrandrunchavecheckpointfeature, so it would be cool ifnerdctlalso had it. I'd say CRIU is quite stable, just that it depends on the Linux kernel which may have bugs and new features.
podman also supports checkpoint, looking forward to nerdctl to support it also
