nerdctl
nerdctl copied to clipboard
Fixed volume mount issue(759) for Windows
Fixed issue #759 :
- volume binding issue in Windows containers
D:\GolandProjects\github.com\nerdctl2\cmd\nerdctl>nerdctl run -it -v C:\ProgramData\nerdctl\052055e3\volumes\default\test\_data:c:\src mcr.microsoft.com/windows/nanoserver:20H2
Microsoft Windows [Version 10.0.19042.1586]
(c) 2019 Microsoft Corporation. All rights reserved.
C:\Windows\system32>cd ../..
C:\>dir
Volume in drive C has no label.
Volume Serial Number is 7643-AF54
Directory of C:\
03/03/2022 01:27 PM 5,510 License.txt
03/16/2022 07:00 PM <DIR> src
03/16/2022 07:50 PM <DIR> Users
03/16/2022 07:50 PM <DIR> Windows
1 File(s) 5,510 bytes
3 Dir(s) 21,302,005,760 bytes free
C:\>
When using nerdctl + containerd on Windows, I am able to mount volumes or bind mount to a new windows container.
Signed-off-by: Raymond Mathew [email protected] Signed-off-by: Dasara Nagaraju [email protected]
Commits 25
Please remove irrelevant commits and squash your ones. Just like other PRs: https://github.com/containerd/nerdctl/pulls?q=is%3Apr+is%3Amerged
@jsturtevant Could you take a look?
I think we've gotten pretty far on this. I would be inclined to merge and iterate. The last comment I have a concern on is https://github.com/containerd/nerdctl/pull/924/files#r871565970. @AkihiroSuda do you know what that fstype is used for and if it is a required for freebsd or linux?