nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

add attach command

Open ningmingxiao opened this issue 3 years ago • 6 comments

Signed-off-by: ningmingxiao [email protected]

ningmingxiao avatar Jan 27 '22 15:01 ningmingxiao

Thanks, but this needs tests.

Also, I guess we don't support attaching multiple terminals to a single container and we have to document that.

AkihiroSuda avatar Jan 28 '22 04:01 AkihiroSuda

I use nerdctl run a container and then nerdctl attach it,it will not work. but use crictl run a container then nerdctl attach it will work

ningmingxiao avatar Jan 28 '22 06:01 ningmingxiao

I use nerdctl run a container and then nerdctl attach it,it will not work. but use crictl run a container then nerdctl attach it will work

Please document that in README.md and nerdctl attach --help

AkihiroSuda avatar Mar 02 '22 10:03 AkihiroSuda

@ningmingxiao are you planning to continue working on his PR ?

fahedouch avatar Jun 12 '22 18:06 fahedouch

@ningmingxiao are you planning to continue working ont his PR ?

when i use nerdctl run a container then i use nerdctl attach it, but it will not work, but if i use crictl run a container then nerdctl attach will work well, so i can't wirte testcase ,do you have some advices? @fahedouch @AkihiroSuda

ningmingxiao avatar Jun 13 '22 03:06 ningmingxiao

nerdctl run -d different from crictl/ctr tools, IO sets of task is a log URI. see https://github.com/containerd/nerdctl/blob/master/pkg/taskutil/taskutil.go#L54-L60

junnplus avatar Jul 16 '22 16:07 junnplus

Closing, as we merged #2108

AkihiroSuda avatar Mar 13 '24 07:03 AkihiroSuda