nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

Published 20 hours ago • verified publisher icon containerd

Improve compose: build individual services and create up services test

Open DamiaPoquet opened this issue 3 years ago • 3 comments

Related with:

  • #456

This pull request adds:

  • Test for nerdctl compose up with services in args
  • nerdctl compose build with services in args

DamiaPoquet avatar Oct 22 '21 16:10 DamiaPoquet

why not using testutil.WordpressImage or testutil.NginxAlpineImage image for your test cases ?

fahedouch avatar Oct 24 '21 21:10 fahedouch

@DamiaPoquet Could you address the feedback from @fahedouch ?

AkihiroSuda avatar Nov 02 '21 04:11 AkihiroSuda

Is this abandoned? @DamiaPoquet Maybe someone else can make a new MR with parts from this?

Anutrix avatar May 28 '22 06:05 Anutrix

This feature is implemented in https://github.com/containerd/nerdctl/pull/1479. Maybe we can close this PR @DamiaPoquet, @AkihiroSuda?

@DamiaPoquet thanks for your contribution! Please feel free to pick any good first issue or other issues that intereste you, and ping if you need any help :)

djdongjin avatar Dec 20 '22 01:12 djdongjin