nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

allow image index type for oci-layout

Open panekj opened this issue 8 months ago • 6 comments

OCI specification allows either image.index or image.manifest for each manifest descriptor in OCI layout https://github.com/opencontainers/image-spec/blob/c05acf7eb327dae4704a4efe01253a0e60af6b34/image-layout.md?plain=1#L153

panekj avatar Apr 05 '25 09:04 panekj

How to test this?

AkihiroSuda avatar Apr 07 '25 02:04 AkihiroSuda

How to test this?

Generally speaking, wondering if we would need some tooling to manually author and push manifests - that would allow testing how we behave in the face of broken / unsupported / maliciously crafted manifests.

That would be a bit of work, but not completely unrealistic.

apostasie avatar May 03 '25 19:05 apostasie

(comment above does not imply support for this specific change here - I am scratching my head as to what the use-case for it is?)

apostasie avatar May 03 '25 19:05 apostasie

How to test this?

I'm not going to provide anything specific for nerdctl as I don't know the project nor have found any testing that would apply for this, but building image using different tool (e.g. Docker) and try to load it with nerdctl should reveal any issues (i hope).

I am scratching my head as to what the use-case for it is?

I am scratching my head as to why I have to provide reasoning for adjusting project to a spec, but above described "test" may suffice?

panekj avatar Jun 11 '25 16:06 panekj

How did you actually test this PR?

AkihiroSuda avatar Jun 12 '25 05:06 AkihiroSuda

How to test this?

I'm not going to provide anything specific for nerdctl as I don't know the project nor have found any testing that would apply for this, but building image using different tool (e.g. Docker) and try to load it with nerdctl should reveal any issues (i hope).

I am scratching my head as to what the use-case for it is?

I am scratching my head as to why I have to provide reasoning for adjusting project to a spec, but above described "test" may suffice?

Did not mean this in any offensive nor dismissive way. I am just trying to understand how to test this, what concrete use-cases are out there that we can codify as tests here to ensure this is working as expected. Peace.

apostasie avatar Jun 12 '25 23:06 apostasie