nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

Build tags for optional features?

Open apostasie opened this issue 1 year ago • 3 comments

What is the problem you're trying to solve

Optional / experimental features (IPFS, stargz, nydus, overlaybd, etc) do introduce a fair amount of code and a number of tests that implementors may not be interested in (wether with straight nerdctl builds, or custom cli based on the codebase).

This is especially impactful as IPFS/stargz testing for example is very flimsy and failing builds a lot.

Suggestion here would be to introduce build tags for these to make it either to not compile support in / not test it.

WDYT?

Tagging @AkihiroSuda

Describe the solution you'd like

na

Additional context

No response

apostasie avatar Sep 25 '24 05:09 apostasie

NERDCTL_EXPERIMENTAL=0 (run-time env var) isn't enough?

AkihiroSuda avatar Sep 25 '24 07:09 AkihiroSuda

NERDCTL_EXPERIMENTAL=0 (run-time env var) isn't enough?

That works only for the nerdctl binary right? Custom cli using the repo as a library will not benefit from it.

The concern outlined in this ticket is not for end-users using the vanilla nerdctl, but for embedders / developers of custom clis.

Anyhow, this is somewhat low-priority. If you don't like it, we can close - otherwise I may look into it later.

apostasie avatar Sep 25 '24 18:09 apostasie

What scares me is having silent errors in the binaries once the corresponding tests are muted. We mustn't forget that these features are built-in in nerdctl and delivering this binary with erroneous features seems like a problem

fahedouch avatar Jun 22 '25 08:06 fahedouch