nerdctl
nerdctl copied to clipboard
fix: restart lark loguri cause start failed
if the container was not created by nerdctl, by default logURI args is empty.
https://github.com/containerd/nerdctl/blob/d273fd202abdf8153cc7d8739fc1a2eda1a9efc1/pkg/cmd/container/create.go#L178
when exec nerdctl restart, it will use logURI start log path, then will cause
FATA[0000] 1 errors: failed to start binary process with cmdArgs []: exec: no command
https://github.com/containerd/nerdctl/blob/d273fd202abdf8153cc7d8739fc1a2eda1a9efc1/pkg/cioutil/container_io.go#L179
ref: https://github.com/containerd/nerdctl/issues/1274 i changed this code and encountered another problem!! hope for reply
Can we have a test?
Hey @Howie59 Thanks for this! Do you think you would be able to add a test for it and comment the code so that we can merge this?