nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

fix: restart lark loguri cause start failed

Open Howie59 opened this issue 1 year ago • 3 comments

if the container was not created by nerdctl, by default logURI args is empty. https://github.com/containerd/nerdctl/blob/d273fd202abdf8153cc7d8739fc1a2eda1a9efc1/pkg/cmd/container/create.go#L178 when exec nerdctl restart, it will use logURI start log path, then will cause FATA[0000] 1 errors: failed to start binary process with cmdArgs []: exec: no command

https://github.com/containerd/nerdctl/blob/d273fd202abdf8153cc7d8739fc1a2eda1a9efc1/pkg/cioutil/container_io.go#L179

Howie59 avatar Jul 15 '24 14:07 Howie59

ref: https://github.com/containerd/nerdctl/issues/1274 i changed this code and encountered another problem!! hope for reply

Howie59 avatar Jul 15 '24 14:07 Howie59

Can we have a test?

AkihiroSuda avatar Jul 16 '24 06:07 AkihiroSuda

Hey @Howie59 Thanks for this! Do you think you would be able to add a test for it and comment the code so that we can merge this?

apostasie avatar Aug 18 '24 23:08 apostasie