containerd
Lint with `shellcheck`
fd -e sh finds all files with .sh extension and passes the names to shellcheck.
Reverting https://github.com/abitrolly/nerdctl/commit/87d83faa5a1281c87946afdb5319ba4e60ca5061 didn't help.
Reverting 4191964f849c03c8864c38efb604f0c5a65a7804 doesn't seem to help either.
@fahedouch lint warnings fixed. Any ideas why rootless tests fail?
Hey @abitrolly
I have been working on something similar, introducing shellcheck as a Makefile target: #3213 - and fixing some of the issues here: #3214
This is clearly duplicating your effort here - I am really sorry about that, as I had not noticed your PR.
I am of course happy to close my PRs if you want to carry yours forward and fix the rootless issue.
LMK your thoughts.
Reverting 4191964 doesn't seem to help either.
@fahedouch lint warnings fixed. Any ideas why rootless tests fail?
Yes. You are quoting the extra arguments for containerd, which will break the startup call with systemd.
@apostasie you clearly possess more knowledge than I in bash shenanigans. So feel free to commit another more clear PR and I'll close this. Or maybe you will find it easier to commit here, if you're among maintainers.
I am just blindly obeying shellcheck instructions. )
@abitrolly Yeah, bash and I have been in a love/hate/want-to-kill-you type of relationship for a long time :P
I am not a maintainer so cannot merge. Let see what I can get in on my PRs and reconvene here.
Thanks again!
Rebased. So now there is only CI command, but also a lot of empty commits that are not removed by rebase --force --empty drop.
After rebasing with --no-keep-empty, the PR now only contains CI code for enabling shellcheck.