nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

Support SOCI snapshotter

Open AkihiroSuda opened this issue 3 years ago • 1 comments

https://github.com/awslabs/soci-snapshotter

AkihiroSuda avatar Aug 20 '22 02:08 AkihiroSuda

I'm interested about this feature, maybe I can make a try(

Zheaoli avatar Aug 20 '22 14:08 Zheaoli

@Zheaoli I'd like to work on this if you haven't started :)

djdongjin avatar Nov 17 '22 19:11 djdongjin

@Zheaoli I'd like to work on this if you haven't started :)

Sorry about this,I have worked on it already :)

Zheaoli avatar Nov 18 '22 02:11 Zheaoli

np :) let me know if you need a review when the PR is out and I'd like to learn more about it

djdongjin avatar Nov 18 '22 02:11 djdongjin

@AkihiroSuda Do you think we can just package SOCI in nerdctl-full at the same time of supporting soci pull and run? SOCI is around 20MB now. https://github.com/awslabs/soci-snapshotter/releases

ningziwen avatar Jul 15 '23 00:07 ningziwen

@AkihiroSuda Hi, I'm working on #2347 to support soci in pull and run. I'm also wondering if SOCI could be packaged in nerdctl-full.

CodeChanning avatar Jul 18 '23 22:07 CodeChanning

@AkihiroSuda Do you think we can just package SOCI in nerdctl-full at the same time of supporting soci pull and run? SOCI is around 20MB now. https://github.com/awslabs/soci-snapshotter/releases

I fear that we will end up including every third party snapshotter in the nerdctl-full bundle, so I'm not inclined to do that.

This is still negotiable, but if we are going to including SOCI (and other snapshotters) in the nerdctl-full bundle, probably we should rename the current nerdctl-full to something like nerdctl-large. Lima will use nerdctl-large (w/o SOCI) by default, but Finch may use the new nerdctl-full (w/ SOCI) by default.

AkihiroSuda avatar Jul 19 '23 14:07 AkihiroSuda

@AkihiroSuda Sounds good. For the current change, we will just exclude SOCI from nerdctl distribution.

I think other dependencies like Cosign, Notation are in the same situation.

In the future, we can potentially include them in nerdctl-full and keep current one as nerdctl-large or nerdctl-core.

Letting downstream manage the dependencies by themselves is also not bad. (Package their own nerdctl tar and overwrite in Lima local archive) This can offload the logic of nerdctl distribution.

ningziwen avatar Jul 23 '23 19:07 ningziwen

@AkihiroSuda Should we resolve the issue?

ningziwen avatar Sep 19 '23 02:09 ningziwen