nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard
verified publisher icon containerd

container logs do not invoke logs cmd

Open fahedouch opened this issue 3 years ago • 1 comments

PR fixes :

  • nerdctl compose logs no longer rely on nerdctl logs
  • nerdctl compose up log output no longer rely on nerdctl logs
  • refacto nerdctl logs

And fixing https://github.com/containerd/nerdctl/issues/1071 Signed-off-by: Fahed DORGAA [email protected]

fahedouch avatar Jun 09 '22 19:06 fahedouch

Thanks, but this PR seems too huge for fixing #1071 , and the tests are failing.

Let me merge https://github.com/containerd/nerdctl/pull/1132 instead

AkihiroSuda avatar Jun 17 '22 14:06 AkihiroSuda