go-cni icon indicating copy to clipboard operation
go-cni copied to clipboard

Some use issue about `WithArgs` in namespace_opts.go

Open Zheaoli opened this issue 3 years ago • 1 comments

Hello all,

I got some special issue about WithArgs in namespace_opts.go. For right now, the code below

func WithArgs(k, v string) NamespaceOpts {
	return func(c *Namespace) error {
		c.args[k] = v
		return nil
	}
}

Just allow people to use string as value when calling this function. But in the specification, the value may be a slice type. FYI https://www.cni.dev/docs/conventions/#args-in-network-config

I'm not sure if there is some mistake?

Zheaoli avatar Mar 13 '22 05:03 Zheaoli

https://github.com/containerd/go-cni/pull/14

Zheaoli avatar Mar 13 '22 05:03 Zheaoli