go-cni icon indicating copy to clipboard operation
go-cni copied to clipboard

Fix dead link for bandwidth plugin comment

Open MikeZappa87 opened this issue 4 years ago • 4 comments

Resolving a dead link for the bandwidth plugin.

Resolves Issue: https://github.com/containerd/go-cni/issues/78

MikeZappa87 avatar Dec 24 '21 01:12 MikeZappa87

Codecov Report

Merging #79 (4f53315) into main (aa8bf14) will increase coverage by 1.68%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   42.23%   43.91%   +1.68%     
==========================================
  Files           9        9              
  Lines         367      378      +11     
==========================================
+ Hits          155      166      +11     
  Misses        181      181              
  Partials       31       31              
Impacted Files Coverage Δ
namespace_opts.go 0.00% <ø> (ø)
cni.go 74.03% <0.00%> (+3.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa8bf14...4f53315. Read the comment docs.

codecov-commenter avatar Dec 24 '21 01:12 codecov-commenter

needs a rebase

estesp avatar Apr 18 '22 14:04 estesp

@MikeZappa87 if this is still valid, we should get this in..looks like it fell between the cracks

estesp avatar Oct 27 '22 15:10 estesp

I need to get this merged, can do this weekend

On Thu, Oct 27, 2022 at 11:15 AM Phil Estes @.***> wrote:

@MikeZappa87 https://github.com/MikeZappa87 if this is still valid, we should get this in..looks like it fell between the cracks

— Reply to this email directly, view it on GitHub https://github.com/containerd/go-cni/pull/79#issuecomment-1293688820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOW3MYFV24ZTYWSHAWOCSL3WFKMAXANCNFSM5KVZXCKQ . You are receiving this because you were mentioned.Message ID: @.***>

MikeZappa87 avatar Oct 27 '22 15:10 MikeZappa87

Maybe I should get this done!

MikeZappa87 avatar Aug 02 '23 03:08 MikeZappa87