containerd icon indicating copy to clipboard operation
containerd copied to clipboard

sandbox: add event monitor for podsandbox controller

Open abel-von opened this issue 1 year ago • 2 comments

Currently the podsandbox controller has to get event monitor from CRI plugin, that makes the podsandbox controller dependent on the CRI plugin, this PR decouples it by create a event monitor for podsandbox controller independently.

abel-von avatar Jan 03 '24 08:01 abel-von

Hi @abel-von. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 03 '24 08:01 k8s-ci-robot

needs to rebase after #9463 is merged

abel-von avatar Jan 03 '24 08:01 abel-von

/cc @mxpv @fuweid

abel-von avatar Feb 21 '24 03:02 abel-von

needs-rebase after #9617 is merged

abel-von avatar Feb 21 '24 03:02 abel-von

As https://github.com/containerd/containerd/pull/9617 is merged, this PR is rebased now, could you please take a look at it again? @fuweid @mxpv

abel-von avatar Feb 29 '24 07:02 abel-von

Will take a look in two days. Thanks!

fuweid avatar Feb 29 '24 12:02 fuweid

/ok-to-test

mxpv avatar Mar 05 '24 01:03 mxpv

@fuweid PTAL

mxpv avatar Mar 05 '24 01:03 mxpv

/retest

fuweid avatar Mar 05 '24 05:03 fuweid