containerd icon indicating copy to clipboard operation
containerd copied to clipboard

Fix taskMonitor leak when shim killed

Open cardyok opened this issue 3 years ago • 1 comments

When shim process is unexpectedly killed, task.Delete might be invoked after metadata has been removed in onClose function and monitor.Stop will be skipped thus leading to taskMonitor data leak.

Fixes #6685

Signed-off-by: cardy.tang [email protected]

cardyok avatar May 23 '22 13:05 cardyok

Hi @cardyok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 23 '22 13:05 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 29 '23 07:11 k8s-ci-robot

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

github-actions[bot] avatar Apr 12 '24 00:04 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 16 '24 00:05 github-actions[bot]