containerd icon indicating copy to clipboard operation
containerd copied to clipboard

sandbox: do retry for wait to remote sandbox controller

Open abel-von opened this issue 9 months ago • 7 comments

For remote sandbox controllers, the controller process may restart, we have to retry if the error indicates that it is the grpc disconnection.

abel-von avatar May 10 '24 02:05 abel-von

Hi @abel-von. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 10 '24 02:05 k8s-ci-robot

/ok-to-test

Burning1020 avatar May 15 '24 01:05 Burning1020

/retest

kzys avatar May 15 '24 22:05 kzys

/cc @mxpv @mikebrow @dmcgowan @fuweid

abel-von avatar May 17 '24 01:05 abel-von

/cc @fuweid

abel-von avatar May 17 '24 01:05 abel-von

I like this, and may argue that it wouldn't hurt to do this in all cases, not just remote sandbox controller.

cpuguy83 avatar May 22 '24 21:05 cpuguy83

For reference https://github.com/cpuguy83/containerd-shim-systemd-v1 which does not really make sense as a sandbox controller but would likely be worth it to implement even just for this change.

cpuguy83 avatar May 22 '24 21:05 cpuguy83