containerd.io icon indicating copy to clipboard operation
containerd.io copied to clipboard

Windows binaries missing from the release page

Open rgl opened this issue 4 years ago • 12 comments

Description

At the https://containerd.io/ homepage there's this paragraph:

containerd is available as a daemon for Linux and Windows.

But at the release page (e.g. https://github.com/containerd/containerd/releases/tag/v1.3.3) there is only the linux binaries (e.g. containerd-1.3.3.linux-amd64.tar.gz).

Describe the results you expected:

A windows binary in the release page.

rgl avatar Mar 21 '20 11:03 rgl

Who is building and/or releasing containerd for Windows? @Random-Liu or @jterry75 do you all know?

estesp avatar Mar 24 '20 15:03 estesp

@kevpar Can you help look into this?

marosset avatar May 04 '20 20:05 marosset

We (Microsoft) don't currently release containerd for Windows. @estesp what would be needed to add a Windows build to the containerd release process?

kevpar avatar May 04 '20 22:05 kevpar

I noticed there are windows binaries nightly builds of containerd at https://github.com/containerd/containerd/actions/runs/94784795 It would be good to include them in for releases as well.

marosset avatar May 04 '20 22:05 marosset

/cc @cpuguy83

marosset avatar May 12 '20 20:05 marosset

Should we build hcs shim along with it?

cpuguy83 avatar May 12 '20 22:05 cpuguy83

I can help with this, how are assets uploaded to the release in the first place?

I couldn't find any references in https://github.com/containerd/release-tool

seemethere avatar May 15 '20 00:05 seemethere

The release-tool just generates the tag and release notes. Travis doing the builds today. Since Travis is broken I have been building locally and pushing up. We hope to get these moved over to Github actions by 1.4 final. Hopefully building windows and linux, and arm64 but that is a stretch goal right now.

dmcgowan avatar May 15 '20 04:05 dmcgowan

Releases are now triggered by GH action, and Windows builds are included. Currently this is only on 1.4 beta1.

cpuguy83 avatar Jun 02 '20 23:06 cpuguy83

v1.3.5 also includes Windows binaries now.

cpuguy83 avatar Jun 30 '20 20:06 cpuguy83

Shouldn't the windows binaries be available under Downloads on https://containerd.io?

khatrig avatar Aug 07 '21 16:08 khatrig

When the website was designed we didn't have Windows support; I just moved this issue to the website repo and am re-opening it so we can fix this now that we have official Windows releases.

estesp avatar Aug 18 '21 03:08 estesp