containerd
hero and navbar improvements
Signed-off-by: Priyanshu Singh [email protected]
made changes to hero section and navbar, as part of initial changes. Improved their look. Please provide your feedback or any changes.
you need to squash these 2 commits into one since the whitespace and DCO checking happens on each commit in the pull request. Let me know if you need help, but that should get you a clean CI run so we can review.
ok, i reset the branch, did a new commit . but after that it's telling me to pull and when i pull, it is merging branches and in that merge that previous failed check commits are present. So it's quite a situation here.
Looks like a nice refresh to some of the UI elements on the main page; anyone else @containerd/committers have an opinion?
I agree it is a nice refresh, a few questions/comments
- Where does the background blue come from, is it used somewhere else for consistency?
- The "Getting Started" button could have more contrast with the background so it pops out a little more
- "containerd Branding" or "containerd branding", we always keep references to the project as lower case, even in titles.
I agree it is a nice refresh, a few questions/comments
- Where does the background blue come from, is it used somewhere else for consistency?
- The "Getting Started" button could have more contrast with the background so it pops out a little more
- "containerd Branding" or "containerd branding", we always keep references to the project as lower case, even in titles.
- I have used the background just for header and hero currently, I will apply the background to the footer and features section as well, that would give a nice scroll effect on the section and would be consistent as well. I used blue just to give a dark background with light text on it like the current one where a blackish shade is present. If it doesn't look great, I can try some other dark shades or try to do a vice-versa, a lighter background with dark text.
- Ok I will change that to some light color so that it stands out and is clearly visible as well.
- I'll change that to lower case.
Need rebase to remove merge commit. Also either remove the npm packages lock or if necessary move under the node.js comment
removed the package-lock file. Also can you do the rebase while merging the PR. Trying to do that locally can become quite messy.
Here are a few screenshots illustrating design issues that appear for narrow views:
-
Top-nav containerd logo is clipped:
-
IMHO, the top-nav logo is too big (the previous size seemed better).
-
IMHO, the CTA buttons are too big (see the screen shot above).
-
The vertical logo doesn't work for narrow displays:
- The social media buttons in the footer are too big (the previous size was ok). They used to fit nicely together in the default view, but they don't anymore
- The top-nav color needs to be adjusted for doc pages:
/cc @nate-double-u
Hii chalin, i was waiting for the final confirmation for the design and had made changes initially for the laptop size only, that's why the site has some issues at smaller screen size.
I completely agree with everything you said @chalin Also, the flipped logo doesn't sit well with the overall design.
I suggest we revert the logo to be horizontally positioned.
I kinda like the new background image; makes it look fresh. My only concern is that it replaces the brand color.
Btw, great work @reveurguy; you got this!
Thanks @reveurguy, I'll let @thisisobate have a look at the updates when he has the time.
@amye and/or @caniszczyk: any comments about the change in colors proposed by this PR, and whether that's an issue in terms of containerd branding, given the current color palette of containerd logos.
/cc @nate-double-u
Thanks for your patience. Again, I'll let @thisisobate follow up on this (he's currently out -- or soon will be -- for the holidays if I'm not mistaken).
Btw, when working on the burger contrast issue, consider increasing the height of .navbar-burger span to 2px. That'll help make it more visible.