console icon indicating copy to clipboard operation
console copied to clipboard

fix: add solaris to non-supported shim.

Open jperkin opened this issue 1 year ago • 2 comments

Hi!

This completes the removal of solaris support, and ensure that those of us on illumos can continue to build projects such as minio that depend on this module. Tested both on macOS via GOOS=solaris GOARCH=amd64 as well as natively on illumos.

If anyone is interested I also have initial native support for illumos at https://github.com/jperkin/console/tree/illumos but as per my commit there I'm at a bit of an impasse. I'll leave that for another day.

Thanks!

jperkin avatar Mar 22 '24 15:03 jperkin

Hi @jperkin, for the failing CI check could you sign the commit. Check out this link https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work for the details.

austinvazquez avatar Mar 22 '24 17:03 austinvazquez

Done, thanks.

jperkin avatar Mar 22 '24 17:03 jperkin