spec icon indicating copy to clipboard operation
spec copied to clipboard

Move volume mount group feature GA

Open gnufied opened this issue 2 years ago • 3 comments

Drop alpha from volume_mount_group feature.

gnufied avatar Jun 08 '22 18:06 gnufied

is this the first time we've promoted something from alpha to GA? i'm wondering if there's a compatibility impact w/ respect to completely dropping the alpha annotations vs. setting them to false. maybe i'm overthinking this. has anyone tested interactions between older bindings (w/ alpha set) against newer bindings (w/o alpha)?

jdef avatar Jun 08 '22 19:06 jdef

This is another instance https://github.com/container-storage-interface/spec/pull/499 when we moved things over from alpha to GA. I will look into compatibility aspects of when we move a feature from alpha to GA.

gnufied avatar Jun 08 '22 19:06 gnufied

@jdef So I ran e2e of k8s by updating kubernetes with my version of CSI driver and let driver run a released version of CSI with alpha APIs. And all e2es are still passing:

  should pass FSGroup to CSI driver if it is set in pod and driver supports VOLUME_MOUNT_GROUP                                                                                                                                                               
    should not pass FSGroup to CSI driver if it is set in pod and driver does not supports VOLUME_MOUNT_GROUP                                                                                                                                                         

Is that enough as signal that dropping alpha annotation does not break anything?

gnufied avatar Oct 17 '22 20:10 gnufied

/cc @saad-ali

jingxu97 avatar Oct 19 '22 17:10 jingxu97