spec icon indicating copy to clipboard operation
spec copied to clipboard

NodeStageVolume is missing readonly field

Open saad-ali opened this issue 5 years ago • 0 comments

@cduchesne rightfully pointed out that the NodeStageVolumeRequest is missing the bool readonly field which ControllerPublishVolumeRequest and NodePublishVolumeRequest both have. So a driver doesn't know when a global mount should be mounted readonly. Effectivley this is not a huge issue since the final NodePublishVolumeRequest mount does have this information. But ideally we should ensure that even for NodeStageVolumeRequest the right thing happens. Areas to think about: 1) how to add this in a backwards compatible way, 2) if a CO has multiple workloads using the same volume on the same node with a storage system that implements NodeStageVolumeRequest but the first workload requests readonly and the second workload requrests readwrite.

CC @davidz627

saad-ali avatar Feb 13 '20 00:02 saad-ali