consuldemocracy icon indicating copy to clipboard operation
consuldemocracy copied to clipboard

Bump font-awesome-sass from 5.15.1 to 6.4.0

Open karim-semmoud opened this issue 2 years ago • 2 comments

Reference

https://fontawesome.com/docs/web/use-with/ruby-on-rails https://fontawesome.com/docs/web/setup/upgrade/ Relates to #4974

Objectives

This pull request aims at upgrading Font Awesome from 5.15.1 to 6.4.0 -Update the gem version -Update SCSS import -Upload 6.4.0 SVG icons -Rename depreciated icons name

karim-semmoud avatar Jun 18 '23 23:06 karim-semmoud

Hi, @karim-semmoud :smile:.

Thanks a lot for this pull request! :tada: We got stuck when trying to do the upgrade last year and postponed it, and this pull request helps a lot.

We've got a few things on our schedule and aren't sure when we'll be able to review this pull request. Sorry for that! In the meantime, could you provide the link where you downloaded the icons from?

Thanks!

javierm avatar Jun 22 '23 00:06 javierm

Hi @javierm There is no rush for it as it is not essential and the version 6 doesn't bring much more, except new icons mainly

I downloaded the full SVG set for the 6.4.0 For The Web (Free) https://fontawesome.com/download https://use.fontawesome.com/releases/v6.4.0/fontawesome-free-6.4.0-web.zip

Let me know if you need me for anything

karim-semmoud avatar Jun 23 '23 04:06 karim-semmoud

Hi, @karim-semmoud :smile:.

Are you still working on this pull request? :thinking: If you aren't, that's fine :ok_hand:; we'll open a new pull request while keeping you as the author of the commits.

javierm avatar Mar 26 '24 19:03 javierm

Hi @javierm I am not working on this anymore but feel free to use the previous commits

karim-semmoud avatar Mar 26 '24 19:03 karim-semmoud

@karim-semmoud Thank you once again for everything you've done in this pull request :pray:.

Closing in favor of #5449.

javierm avatar Mar 26 '24 22:03 javierm