consuldemocracy icon indicating copy to clipboard operation
consuldemocracy copied to clipboard

Homepage cards improvements

Open decabeza opened this issue 7 years ago • 4 comments

Background

Now the homepage is customizable from Admin section in /admin/homepage, but there are some things that need to be improved.

What we need

  • The form to create cards doesn't have validations (all fields should be required except the optional label)

  • The title and the label of a card don't appear if there's no picture (should be required).

Review

  • The text of the 'Save card' button changes to <span class=&quot;translation_missing&quot; title=&quot;translation missing: en.admin.homepage.update.submit_card&quot;>Submit Card</span> when there is an error in the card form.

  • In the card form, the image is displayed cropped and enlarged for no reason (this seems work fine).

decabeza avatar Jun 21 '18 16:06 decabeza

@decabeza I'd like to take this up.

viren140290 avatar Aug 28 '18 03:08 viren140290

@viren140290 Go ahead! Thank you!

(I'm the one replying because decabeza is on holidays :beach_umbrella:).

javierm avatar Aug 28 '18 09:08 javierm

@viren140290 Are you still working on this issue?

javierm avatar Oct 20 '19 19:10 javierm

I can work on this issue. =)

iraline avatar Jun 10 '22 18:06 iraline