Constantine Genchevsky

Results 55 comments of Constantine Genchevsky

Now it looks ok. But unfortunately I have no rights to merge these changes. I am not a collaborator of this project. Lets hope @nairinarinyan will respond quickly. Or may...

It should be possible to not put semicolon as it is valid CSS. Specs says that is is not a "line end" but "delimiter" between properties. I think the origin...

@nairinarinyan can you merge this please? It resolves many issues in CSS corruption produced by this plugin.

Some time it is necessary to put all side effects in a correct spot (at the very top or the very bottom) which actually can prevent a lot of bugs....

I can still reproduce it on ``` css-minimizer-webpack-plugin 4.0.0 └── cssnano 5.1.12 ```

I can see in the build logs that the job published packages to NPM. But why? It even didn't pass the code formatting check. And this is only Pull Request.

Here are my thoughts. I have my personal set of Neutrino middlewares and presets for React, ESLint and other. I reuse couple of Neutrino core middlewares, but most are custom....

Please, look at the new section in the documentation https://github.com/constgen/neutrino-dev/tree/pnp/packages/eslint#utility-functions

I think everything related to Yarn 2 is resolved. The only left are tests. And I think there is a separate problem. I feel like tests can affect each other...

@edmorley in Webpack 5 only `pnp-webpack-plugin` will be not necessary. All other fixes to ESLint, Jest and etc. will be highly required. Their issues still remain. So with `pnp-webpack-plugin` or...