Analytic view lag

[formalhaut69]

Prerequisites

• [ ] Put an X between the brackets on this line if you have done all of the following:
  • Running the latest version of Constellation
  • Attached the Support Package via Help > Support Package
  • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
  • Checked that your issue isn't already filed: https://github.com/constellation-app/constellation/issues
  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

The analytic view can lag after several different plugins are used.

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

Expected behaviour: [What you expect to happen]

Actual behaviour: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

[formalhaut69]

Tested this issue in V1 and it also occurs there, I'll remove the RC1 tag. To reproduce this issue, I selected each analytic from each category and then ran them several times.

[cygnus-x-1]

You can only run analytics from a single category for any single 'run'. When you do, each analytic will be run in it's own thread and the results will be combined when they are all finished executing. If you choose to run more analytics while there analytics are executing, that will work fine, but the old lot won't be cancelled. This means that you could end up running hundreds of rather complex calculations each in their own thread - which would likely cause the lag, particularly if they are all competing for read/write locks on the one graph.

[Nova-2119]

@cygnus-x-1 Do you feel this is a problem that needs addressing? Or something that is kind of unavoidable with this kind of use?

[formalhaut69]

@Nova-2119 I never actually added this into the ticket but for context, I discovered the lag through general use so that's why I thought it might require a ticket.

[arcturus2]

@cygnus-x-1 Do you feel this is a problem that needs addressing? Or something that is kind of unavoidable with this kind of use?

I'd like to investigate this as it could be a memory leak or other performance issues at play.

[Nova-2119]

@Nova-2119 I never actually added this into the ticket but for context, I discovered the lag through general use so that's why I thought it might require a ticket.

Thanks for adding this context :)

@arcturus2 I'll see what I can find!

[Nova-2119]

You can only run analytics from a single category for any single 'run'. When you do, each analytic will be run in it's own thread and the results will be combined when they are all finished executing. If you choose to run more analytics while there analytics are executing, that will work fine, but the old lot won't be cancelled. This means that you could end up running hundreds of rather complex calculations each in their own thread - which would likely cause the lag, particularly if they are all competing for read/write locks on the one graph.

So could a potential way to fix these be to somehow implement a mechanism that holds off starting threads for a second batch until the first batch is finished?

[Nova-2119]

You can only run analytics from a single category for any single 'run'. When you do, each analytic will be run in it's own thread and the results will be combined when they are all finished executing. If you choose to run more analytics while there analytics are executing, that will work fine, but the old lot won't be cancelled. This means that you could end up running hundreds of rather complex calculations each in their own thread - which would likely cause the lag, particularly if they are all competing for read/write locks on the one graph.

So could a potential way to fix these be to somehow implement a mechanism that holds off starting threads for a second batch until the first batch is finished?

Scratch that, the Run button turns into a stop button once a batch of analytics are running, so I think you can only have one batch running at a time.

@formalhaut69 How bad is the lag? I'm unsure whether or not I am able to recreate this issue. I'm getting a slight lag when I switch between analytics, at the very most a second, probably more like half a second, is that the lag you are describing?

[aldebaran30701]

@Nova-2119 I think it is the lag @formalhaut69 referred to. I'm thinking the lag is really just too much occurring on FX threads. If you click one of the drop downs or check-boxes, it takes a second or more to really have a change be displayed. I noticed it getting worse the more you use the view. If you load up the thread by clicking them all a few times fast it seems to get worse.

I think the issue @cygnus-x-1 was mentioning was how the Analytic View actually runs the analytics as opposed to them loading their preferences within the UI. I've experienced this issue before without having to run an analytic. So I think it's more or less related to clicking things like plugins, questions, categories and check boxes.

[GammaVel]

I have observed this behaviour with v2.3 however I noticed it has to be a graph with a large amount of nodes (I had 50) and I had to quickly click on the different categories and run them. Constellation ended up freezing. No issues with a small number of nodes or waiting for each plugin to finish loading.

[github-actions[bot]]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

[github-actions[bot]]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

[GammaVel]

Lag is present in v2.8 however you need to have a larger graph to be able to really notice it. The analytics start to take longer to run and in some case., do not complete within a reasonable time. A small graph is ok.

[github-actions[bot]]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

[github-actions[bot]]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

[GammaVel]

I have taken a look of this in version 2.11 with the latest nightly build (9/02) and the lag is still present. It doesn't show up at the start but as I started to click through the categories and the questions it got more noticeable. This is without actually running the analytics. Looks like there is still some issue there, number of nodes was 1500.