constellation Inconsistency Type resolution

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:
- Running the latest version of Constellation
- Attached the Support Package via Help > Support Package
- Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
- Checked that your issue isn't already filed: https://github.com/constellation-app/constellation/issues
- Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

For the IP 192.168.1.1 there are 3 possible types and using the AnalyticDominanceCalculator the one with highest priority is HOST_NAME so that's why it's getting picked. Below is the output of the possible types when I run the unit test:

Jun 17, 2020 4:34:22 PM au.gov.asd.tac.constellation.graph.schema.type.SchemaVertexTypeUtilities matchVertexTypes
WARNING: Multiple types matched identifier 192.168.1.1: [Network Identifier.IP Address.IPv4 Address, Online Location.Host Name]

Note that if I run the 'Extract Types from Text" plugin and put in 192.168.1.1 I get "IPv4 Address" for the type which is inconsistent to Hostname here. The issue there looks like different methods are used. Split nodes uses SchemaVertexTypeUtilities.matchVertexTypes() and the applies the VertexDominantCalculator whereas "Extract Types from Text" plugin uses SchemaVertexTypeUtilities.extractVertexTypes().

See https://github.com/constellation-app/constellation/pull/568/files/e21df02894d567fd829e0e6839a54b5a58ef4bcd#r441318148 for the original correspondence.

Steps to Reproduce

TDA

Expected behaviour: [What you expect to happen]

Actual behaviour: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Jun 21 '20 19:06 arcturus2

This could be the result of those schema regex changes from a while back.