constellation icon indicating copy to clipboard operation
constellation copied to clipboard

Tidy up the JavaFX stylesheets

Open arcturus2 opened this issue 4 years ago • 4 comments

Prerequisites

  • [X] Put an X between the brackets on this line if you have done all of the following:
    • Running the latest version of Constellation
    • Attached the Support Package via Help > Support Package
    • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
    • Checked that your issue isn't already filed: https://github.com/constellation-app/constellation/issues
    • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

A few things worth investigating:

  • How do ControlsFX manage CSS files and should be use them?
  • How does GLUON manage JavaFX styling and should we use GLUON?
  • What other JavaFX libraries are out there?

A few things I'd like to see implemented:

  • bring back the equvilent JavaFX skins for the Quality Control View
-fx-skin: "com.sun.javafx.scene.control.skin.TableViewSkin";
-fx-skin: "com.sun.javafx.scene.control.skin.TableRowSkin"
-fx-skin: "com.sun.javafx.scene.control.skin.TableCellSkin";
-fx-skin: "com.sun.javafx.scene.control.skin.ButtonSkin";
  • There is more than one Style-Caspian.css file in the project. If this is the main css file then it should be hosted in one package
  • Review the custom .css files and if there are any duplicates then merge them into a common .css file
  • Break out the colours into their own '.css file so we can have light and dark flavours and make it easier to switch between the two.

arcturus2 avatar Mar 19 '20 04:03 arcturus2

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Sep 16 '20 00:09 github-actions[bot]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Mar 15 '21 00:03 github-actions[bot]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Dec 21 '21 01:12 github-actions[bot]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Aug 17 '22 00:08 github-actions[bot]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Feb 23 '23 00:02 github-actions[bot]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Aug 24 '23 00:08 github-actions[bot]

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Feb 26 '24 00:02 github-actions[bot]

Already implemented in PR #1131

capricornunicorn123 avatar Mar 18 '24 04:03 capricornunicorn123