constellation icon indicating copy to clipboard operation
constellation copied to clipboard

Fix Indriya dependency conflict

Open capricornunicorn123 opened this issue 1 month ago • 1 comments

Prerequisites

  • [ ] Reviewed the checklist

  • [ ] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

This change aims to fix the issues that occur when having both Indriya 1.3 and Indriya 2.0.2 in the core dependencies module.

The inclusion of the tag <dependency org="org.languagetool" name="language-en" rev="6.0" conf="languagetoolconf->default" /> drags in a number of jar files which are previous versions of existing Jars in core dependencies. To resolve the issues that these duplications cause, the required dependencies for language-en have been statically included in a new Core Spell Check Module. All spell-checking code has been moved from Utilities to this module.

Alternate Designs

Finding a way for the project to update these Core Spell Check dependencies dynamically would be ideal however I am unsure of how to go about it. I'm not sure if we can have another ivy.xml file in the Core Spell Check module or how we get the build script to use it to update those specific dependencies.

If and when languagetools updates to reference more recent packages, spell check and its dependencies can likely be reintegrated into Core Dependencies and Core Utilities.

Why Should This Be In Core?

Is a core feature. Separating it into a separate project to be layered ontop of core would resolve this dependency issue however would be a bold move for the sake of one feature.

Benefits

It works now ! - yay

Possible Drawbacks

It is a pretty stinky solution 💩

Verification Process

Open the Schema view and note no errors Open the Data Access View and enter misspelt text in the extract words from text field and note the spell check works.

Applicable Issues

#2054

capricornunicorn123 avatar Jun 07 '24 06:06 capricornunicorn123