constellation icon indicating copy to clipboard operation
constellation copied to clipboard

Export to SVG causes the graph to lock indefinitely when interrupted

Open capricornunicorn123 opened this issue 5 months ago • 1 comments

Prerequisites

  • [ ] Put an X between the brackets on this line if you have done all of the following:

    • Running the latest version of Constellation

    • Attached the Support Package via Help > Support Package

    • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ

    • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues

    • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

When exporting a graph to an SVG file there is the potential for a graph to be locked indefinitely. If a user exports a graph, and cancels the export prematurely, the graph is not released by the plugin due to the way the plugin utilizes GraphVisualAccess. This locks the graph. This may be an indication that GraphVisualAccess is not the appropriate utility to use to get visual information from the graph.

Using VisualGraphUtilities would be a more appropriate utility class to use however would require significant work to support the needs to the SVG export plugin.

Steps to Reproduce

  1. Greate a sphere graph with 10000 Nodes

  2. Export the graph to SVG

  3. Cancel the Export

  4. Note the graph has not locked indefinitely.

Expected behaviour: The graph should be released appropriately when the plugin is canceled.

Actual behaviour: The graph locks.

Reproduces how often: When canceled during execution.

Additional Information

N/A

capricornunicorn123 avatar Feb 07 '24 04:02 capricornunicorn123