Layers UI Rework

[aldebaran30701]

Prerequisites

• [x] Reviewed the checklist

• [x] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

This change is based off the design discussion in #1127 It implements new UI components to bring up the consistency to that of the Data access view.

Error handling changes have been implemented within each query dialog based on recent changes to data access view error handling. The image below shows an incorrectly parsed query int he transaction section. When this occurs, the layer is disabled from being toggled, and the titlepane goes red as well as the specific query entry field.

Outstanding work checklist:

• [x] Refresh layers without recreation of each titlepane object
• [x] Ensure layer 0 is toggled when no other layer is enabled (visible feedback to the user that the complete graph is shown)
• [x] Disable the checkbox in layer 0
• [x] Correctly refresh the layers view when the current graph is switched or closed.

Extended:

• [ ] LayerAttributes which track graph changes and update the graph if necessary are not getting stored.
• [x] Toggling a layer more than once doesn't show correct results due to the modcount not changing (code not thinking it needs to recalculate)

Alternate Designs

Alternate designs have been discussed in detail within the main issue ticket. Implementation alternatives have not been discussed as yet.

Why Should This Be In Core?

Enhances consistency of the UI elements throughout different Constellation Views Enhances readability of queries and layers view workflow

Benefits

as above

Possible Drawbacks

none realised

Verification Process

WIP

Applicable Issues

#1127

[aldebaran30701]

I haven't managed to resolve all bugs, but the checkboxes in the description show the remaining tasks.

To add onto this, the recent parameter values have not been fully implemented within the QueryInputPane.

I also noticed there was one case when I entered an invalid query into Vertex section and both vertex and transaction query entries went red. Only the vertex field should do so.

[Delphinus8821]

Just did some testing as well. Found a few things:

1. Are you able to update the first screenshot in the help page? This is a screenshot of the old interface.
2. Looks like the right-click context menu may have the menus a little off with an extra layers menu. Are you able to fix that?
3. Looks like graph elements which are added to a layer via query aren't removed when the query is removed (only when the query is changed). Not sure what the intended behaviour is here but I would think those graph elements should be removed from the layer

@antares1470 Points 1 and 3 should now be fixed. Point 2 is something that has been occurring in the main branch since release v2.5. I will keep looking but at this stage I haven't found a fix for it.

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

68.6% Coverage
2.5% Duplication

[antares1470]

Just did some testing as well. Found a few things:

1. Are you able to update the first screenshot in the help page? This is a screenshot of the old interface.
2. Looks like the right-click context menu may have the menus a little off with an extra layers menu. Are you able to fix that?
3. Looks like graph elements which are added to a layer via query aren't removed when the query is removed (only when the query is changed). Not sure what the intended behaviour is here but I would think those graph elements should be removed from the layer

@antares1470 Points 1 and 3 should now be fixed. Point 2 is something that has been occurring in the main branch since release v2.5. I will keep looking but at this stage I haven't found a fix for it.

Interesting. I'll create a separate ticket for point 2 then