constellation icon indicating copy to clipboard operation
constellation copied to clipboard

Review all Executor thread pools in code

Open antares1470 opened this issue 2 years ago • 1 comments

Prerequisites

  • [x] Put an X between the brackets on this line if you have done all of the following:

    • Running the latest version of Constellation

    • Attached the Support Package via Help > Support Package

    • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ

    • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues

    • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

As mentioned in this comment here https://github.com/constellation-app/constellation/pull/1502#discussion_r731308137, it would probably be worth looking at the all the Executors and other thread pools that exist in the code base and see if there is a way to consolidate them all into one centralised pool. Developers could then tap into this pool of threads rather than create a new thread pool every time they need one to run something.

Behaviour

  • Try to include measurable metrics that can be aimed for (if applicable to the issue), e.g. if it's a time issue then "should take 5 seconds or less to finish" or if it's a workflow issue "should be accomplished in 2 or less clicks".

-->

Expected behaviour: There is one thread pool that jobs can use when needed

Actual behaviour: New thread pools being created every time a thread is required Reproduces how often: ? (definitely more than 0% though)

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

antares1470 avatar Oct 18 '21 23:10 antares1470

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] avatar Apr 17 '22 00:04 github-actions[bot]