constellation Set the LAF to Flat Laf Dark by default

Description of the Change

This is part 1 of 2 to address the LAF. This PR should address #997 and most of #673. Part 2 will address the rest of it.

https://user-images.githubusercontent.com/39325530/124354173-0d156d80-dc4e-11eb-91b7-9ddd65f453fa.mp4

EDIT: In the video above there was some parts that still needed fixing like the advance find view and various dialogs. These have all been fixed now with the latest push.

Alternate Designs

Why Should This Be In Core?

Benefits

Possible Drawbacks

Verification Process

Applicable Issues

Jul 02 '21 05:07 arcturus2

@arcturus2 - it is hard to see the blue color on the buttons on the toolbar with the dark LAF as there is not much contrast.

Jul 05 '21 01:07 GammaVel

@arcturus2 - it is hard to see the blue color on the buttons on the toolbar with the dark LAF as there is not much contrast.

The toolbar icons were redone last year during the v2 upgrade and we did test them on the Dark LAF and Light LAF which was OK at the time (see https://github.com/constellation-app/constellation/pull/607) but I agree that looking at it again now the contrast is not enough.

Jul 05 '21 04:07 arcturus2

@arcturus2 - it is hard to see the blue color on the buttons on the toolbar with the dark LAF as there is not much contrast.

The toolbar icons were redone last year during the v2 upgrade and we did test them on the Dark LAF and Light LAF which was OK at the time (see #607) but I agree that looking at it again now the contrast is not enough.

Yes, I am not color blind but they are hard for me to distinguish.

Jul 05 '21 06:07 GammaVel

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

Jul 28 '21 02:07 sonarqubecloud[bot]

This pull request is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this pull request.

Jan 25 '22 01:01 github-actions[bot]

The work done for ticket #997 may make it unnecessary to force any specific Look and Feel to be used as a default. See PR #1719

Jul 08 '22 04:07 OrionsGuardian

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

16.5% Coverage
0.2% Duplication

Nov 27 '22 16:11 sonarqubecloud[bot]

Ready for a review and feedback.

Nov 27 '22 23:11 arcturus2

There are a few places where the colours are too dark for the theme. ie. in the attribute editor, it is hard to read the attribute names on the blue and red backgrounds: The blue, the red, and also (to a lesser degree) the grey background should have a lighter colour shade so that the black text is easier to read. In doing that, the Edit buttons may also need to be made lighter, and possibly be labelled with black text .

Clicking on the plus button on the attribute_type bar, gives a popup menu: There are too many different variations of blue being used. It should have a common base blue (such as the blue of the Edit button) and have lighter and darker versions of that colour for use in the popup menu. The grey menu background should also be lighter, to match with a lighter grey attribute background.

Dec 01 '22 04:12 OrionsGuardian

This pull request is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this pull request.

May 31 '23 00:05 github-actions[bot]

I'm also still not convinced on all the buttons being blue by default. Could just be me but I think it makes them feel a little out of place with respect to the rest of the color scheme. If there's a reason for the change then happy to hear but in my head I think I feel keeping the button some shade of grey by default would fit better

I personally like the blue buttons everywhere. I would be hesitant to put them back to being all grey again as in some places they can be quite hard to see and if we were to make them grey they can also look like they are inactive or "greyed out"