Idiomatic naming for 6.0?
Maybe the next major release could be a good point to overhaul naming?
-
Rename
TOTPtoTotp? -
Swap
get_prefixes forto_prefixes?
Would you consider a PR that:
- Renames
TOTPtoTotp.- Adds a
typealias,TOTP, forTotp, with a#[deprecated()]note.
- Adds a
- Swaps the
get_prefix from the resp. methods forto_.- Adds methods with the old
get_prefix that just call the new ones and are marked#[deprecated()]and#[inline(always)].
- Adds methods with the old
1.i. and 2.i. would guarantee that old code compiles w/o changes but spits out resp. warnings.
Hi! There is indeed several... Less that fortunate choices of names and exposed API I would like to finally fix, optimally with 6.0 which will probably be more maintenance than actual business logic (in addition to move qrcodegen-image to its own repo).
In addition to TOTP's naming, I would like to review some of the errors (namely Rfc6238Error and Rfc6238's API).
Before adding deprecated notes/new API, I'd like to have a clearer, fuller picture of everything, but you are absolutely right!